fix: check concerto validation result before calling templateFromDatabase#154
Open
JayDS22 wants to merge 1 commit intoaccordproject:mainfrom
Open
fix: check concerto validation result before calling templateFromDatabase#154JayDS22 wants to merge 1 commit intoaccordproject:mainfrom
JayDS22 wants to merge 1 commit intoaccordproject:mainfrom
Conversation
…base templateFromDatabase was called unconditionally before the validation result was inspected. When the body contained invalid data, this caused a raw deserialization exception that masked the structured validation error from concertoValidation. Moved the templateFromDatabase call to after the success check so that invalid payloads return the correct validation error. Fixes accordproject#138 Signed-off-by: Jay Guwalani <guwalanijj@gmail.com>
|
This PR is stale because it has been open 15 days with no activity. Remove stale label or comment or this will be closed in 10 days. |
Author
|
@github-actions unstale |
|
This PR is stale because it has been open 15 days with no activity. Remove stale label or comment or this will be closed in 10 days. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #138
Problem
In
server/handlers/templates.ts, thetemplateValidationfunction calledtemplateFromDatabase(body)before checking whetherconcertoValidationreturned success or failure. When the body was invalid,
templateFromDatabasethrew a deserialization error that got caught by the outer catch block,
masking the structured validation error that concertoValidation had already
produced.
Fix
Moved
templateFromDatabaseto after theresult.successcheck. Invalidpayloads now return the Concerto validation error directly. Template
deserialization only runs on validated data.
How to test
/templateswith a body missing required fieldsDiscord: Jay Guwalani (jayds22)