chore(button): update button component to use strings for badges#2261
Open
dancormier wants to merge 6 commits intomainfrom
Open
chore(button): update button component to use strings for badges#2261dancormier wants to merge 6 commits intomainfrom
dancormier wants to merge 6 commits intomainfrom
Conversation
🦋 Changeset detectedLatest commit: 7429df5 The changes in this PR will be included in the next version bump. Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
✅ Deploy Preview for stacks ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Updates the Stacks Svelte Button
badgeprop to accept a numeric string instead of a snippet.Related Issues
STACKS-812
Original PR #2195
Changes
Buttonbadge typing fromSnippetto numeric string template type.@stackoverflow/stacks-svelte.Testing
Not run; this PR recreates the previously closed branch against
mainwithout local code changes.