Handle visibility in hover#4097
Open
vinistock wants to merge 1 commit intovs_handle_visibility_in_definitionfrom
Open
Handle visibility in hover#4097vinistock wants to merge 1 commit intovs_handle_visibility_in_definitionfrom
vinistock wants to merge 1 commit intovs_handle_visibility_in_definitionfrom
Conversation
vinistock
added
server
19 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
This PR starts using the new visibility APIs to handle hover correctly.
Implementation
This PR is based on the go to definition branch, so I extracted the helpers into
Commonand used it for both.Automated Tests
Added tests ensuring we only show hover for reachable methods and constants.