refactor(Sample-Datasets): replace old table with dynamic-mat-table and fix pagination bugs#2353
Open
refactor(Sample-Datasets): replace old table with dynamic-mat-table and fix pagination bugs#2353
Conversation
Contributor
There was a problem hiding this comment.
Hey - I've left some high level feedback:
- You now have multiple subscriptions to
vm$inSampleDetailComponentthat each handle different concerns (attachments, table data, pagination); consider consolidating these into a single subscription or usingtapin the selector to reduce duplicate subscription logic and make state updates easier to reason about. - Instead of maintaining a
BehaviorSubject<TableData[]>and manually callingnexton eachvm$update, you could expose an observable data source and bind to it directly in the template (e.g., viaasyncpipe), which would simplify the component and reduce state duplication.
Prompt for AI Agents
Please address the comments from this code review:
## Overall Comments
- You now have multiple subscriptions to `vm$` in `SampleDetailComponent` that each handle different concerns (attachments, table data, pagination); consider consolidating these into a single subscription or using `tap` in the selector to reduce duplicate subscription logic and make state updates easier to reason about.
- Instead of maintaining a `BehaviorSubject<TableData[]>` and manually calling `next` on each `vm$` update, you could expose an observable data source and bind to it directly in the template (e.g., via `async` pipe), which would simplify the component and reduce state duplication.Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR replaces the old sample datasets table with dynamic-mat-table and fixes pagination bugs.
Before:

After:

Motivation
Background on use case, changes needed
Fixes:
Please provide a list of the fixes implemented in this PR
Changes:
Please provide a list of the changes implemented by this PR
Tests included
Documentation
official documentation info
If you have updated the official documentation, please provide PR # and URL of the pages where the updates are included
Backend version
Summary by Sourcery
Replace the sample detail datasets table with the shared dynamic material table and align dataset fetching and pagination with server-side APIs.
New Features:
Bug Fixes:
Enhancements: