Skip to content

Refactoring phasor dynamics constituent models#381

Open
PhilipFackler wants to merge 2 commits intodevelopfrom
PhilipFackler/constituent-models
Open

Refactoring phasor dynamics constituent models#381
PhilipFackler wants to merge 2 commits intodevelopfrom
PhilipFackler/constituent-models

Conversation

@PhilipFackler
Copy link
Copy Markdown
Collaborator

Description

This PR removes some duplicate code and makes a small improvement to

Proposed changes

  • Add ConstituentModel as common base for components and buses.
  • Remove SignalNode from evaluator tree (since it doesn't do anything related)

Checklist

  • All tests pass.
  • Code compiles cleanly with flags -Wall -Wpedantic -Wconversion -Wextra.
  • The new code follows GridKit™ style guidelines.
  • [N/A] There are unit tests for the new code.
  • The new code is documented.
  • The feature branch is rebased with respect to the target branch.
  • [N/A] I have updated CHANGELOG.md to reflect the changes in this PR. If this is a minor PR that is part of a larger fix already included in the file, state so.

@PhilipFackler PhilipFackler force-pushed the PhilipFackler/constituent-models branch 2 times, most recently from ae87cf1 to 7694e02 Compare April 24, 2026 18:57
@nkoukpaizan nkoukpaizan added the enhancement New feature or request label Apr 24, 2026
Copy link
Copy Markdown
Collaborator

@pelesh pelesh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perhaps name the new class EvaluatorImpl instead of ConstituentModel? It would be good to have some naming consistency.

Comment thread GridKit/Utilities/Errors.hpp
@PhilipFackler PhilipFackler force-pushed the PhilipFackler/constituent-models branch from 7694e02 to 7230d20 Compare April 27, 2026 22:01
@PhilipFackler
Copy link
Copy Markdown
Collaborator Author

Perhaps name the new class EvaluatorImpl instead of ConstituentModel? It would be good to have some naming consistency.

I changed the name to GridElement as discussed.

@PhilipFackler PhilipFackler requested a review from pelesh April 28, 2026 17:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants