Refactoring phasor dynamics constituent models#381
Open
PhilipFackler wants to merge 2 commits intodevelopfrom
Open
Refactoring phasor dynamics constituent models#381PhilipFackler wants to merge 2 commits intodevelopfrom
PhilipFackler wants to merge 2 commits intodevelopfrom
Conversation
ae87cf1 to
7694e02
Compare
pelesh
reviewed
Apr 27, 2026
Collaborator
pelesh
left a comment
There was a problem hiding this comment.
Perhaps name the new class EvaluatorImpl instead of ConstituentModel? It would be good to have some naming consistency.
…Node from evaluator tree
7694e02 to
7230d20
Compare
Collaborator
Author
I changed the name to |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR removes some duplicate code and makes a small improvement to
Proposed changes
ConstituentModelas common base for components and buses.SignalNodefrom evaluator tree (since it doesn't do anything related)Checklist
-Wall -Wpedantic -Wconversion -Wextra.