Skip to content

[19.0][MIG] hr_contract_employee_calendar_planning#1548

Open
Vicent-C6 wants to merge 25 commits intoOCA:19.0from
Studio73:19.0-mig-hr_contract_employee_calendar_planning
Open

[19.0][MIG] hr_contract_employee_calendar_planning#1548
Vicent-C6 wants to merge 25 commits intoOCA:19.0from
Studio73:19.0-mig-hr_contract_employee_calendar_planning

Conversation

@Vicent-C6
Copy link
Copy Markdown

No description provided.

@Vicent-C6 Vicent-C6 force-pushed the 19.0-mig-hr_contract_employee_calendar_planning branch 2 times, most recently from c58f81f to 03ba64d Compare February 24, 2026 10:28
Copy link
Copy Markdown

@Reyes4711-S73 Reyes4711-S73 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Vicent-C6 Vicent-C6 force-pushed the 19.0-mig-hr_contract_employee_calendar_planning branch from 922ddb9 to e2e43f0 Compare February 25, 2026 07:54
Copy link
Copy Markdown
Contributor

@alexey-pelykh alexey-pelykh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good module — syncing contract calendars with calendar_ids is a real pain point. The post_init_hook migration logic looks thorough.

Tests are failing on OCB and Odoo CI though, and runboat is also red. Likely needs a fix before review can proceed further.

@Vicent-C6
Copy link
Copy Markdown
Author

Vicent-C6 commented Mar 2, 2026

@alexey-pelykh I’ve pushed the test-requirements commit, but it doesn’t seem to work properly. I compared it with other use cases and everything looks fine. Would you mind taking a look?

@alexey-pelykh
Copy link
Copy Markdown
Contributor

@Vicent-S73 The CI failure is because odoo-addon-hr_employee_calendar_planning hasn't been published for 19.0 yet — it's still pending in #1540.

Adding it to test-requirements.txt won't work because the 19.0 package doesn't exist on PyPI. The solution is to not add it to test-requirements and instead wait for #1540 to be merged first, which will trigger the 19.0 package to be published.

In the meantime, the "Detect unreleased dependencies" check is expected to report this as an unreleased dependency. Once #1540 is merged and published, a re-run of this PR's CI should pass.

If you want CI green sooner, you can coordinate to get #1540 merged first (it already has approvals including mine).

@Vicent-C6 Vicent-C6 force-pushed the 19.0-mig-hr_contract_employee_calendar_planning branch 3 times, most recently from 7c4ec97 to 36ea630 Compare March 11, 2026 08:25
jonasbuchholz and others added 17 commits April 2, 2026 09:08
Currently translated at 100.0% (1 of 1 strings)

Translation: hr-15.0/hr-15.0-hr_contract_employee_calendar_planning
Translate-URL: https://translation.odoo-community.org/projects/hr-15-0/hr-15-0-hr_contract_employee_calendar_planning/it/
…ement

- Include context keys for avoiding mail operations overhead.
…creating contracts with different work hours
Updated by "Update PO files to match POT (msgmerge)" hook in Weblate.

Translation: hr-16.0/hr-16.0-hr_contract_employee_calendar_planning
Translate-URL: https://translation.odoo-community.org/projects/hr-16-0/hr-16-0-hr_contract_employee_calendar_planning/
Currently translated at 100.0% (1 of 1 strings)

Translation: hr-16.0/hr-16.0-hr_contract_employee_calendar_planning
Translate-URL: https://translation.odoo-community.org/projects/hr-16-0/hr-16-0-hr_contract_employee_calendar_planning/it/
@Vicent-C6 Vicent-C6 force-pushed the 19.0-mig-hr_contract_employee_calendar_planning branch from 36ea630 to c199888 Compare April 2, 2026 07:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.