[18.0][ADD] hr_work_entry_timesheet: display corresponding timesheet on work entries#1523
Open
remi-filament wants to merge 1 commit intoOCA:18.0from
Open
[18.0][ADD] hr_work_entry_timesheet: display corresponding timesheet on work entries#1523remi-filament wants to merge 1 commit intoOCA:18.0from
remi-filament wants to merge 1 commit intoOCA:18.0from
Conversation
Contributor
alexey-pelykh
left a comment
alexey-pelykh
left a comment
There was a problem hiding this comment.
Interesting module — bridging work entries and timesheets is useful. I see codecov checks are failing though. Might be worth looking into the coverage on the new code paths, especially around _get_work_entry(). The Alpha maturity flag is fair given the scope.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.