Fix StepCurrentSource.set_parameters() after simulation run (issue #759)#831
Merged
apdavison merged 1 commit intoNeuralEnsemble:masterfrom May 5, 2026
Merged
Fix StepCurrentSource.set_parameters() after simulation run (issue #759)#831apdavison merged 1 commit intoNeuralEnsemble:masterfrom
apdavison merged 1 commit intoNeuralEnsemble:masterfrom
Conversation
…uralEnsemble#759) When set_parameters() was called after sim.run(), _check_step_times() used only the timestep (resolution) as the minimum usable amplitude time, ignoring the current simulation time. This produced amplitude_times less than NEST's biological time, causing NEST to silently ignore the current injection. Fix uses state.t_kernel + resolution (NEST biological time + one step) as the threshold, ensuring the adjusted time is always strictly greater than the current biological time. At t=0 the behaviour is identical to before.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When set_parameters() was called after sim.run(), _check_step_times() used only the timestep (resolution) as the minimum usable amplitude time, ignoring the current simulation time. This produced amplitude_times less than NEST's biological time, causing NEST to silently ignore the current injection.
Fix uses state.t_kernel + resolution (NEST biological time + one step) as the threshold, ensuring the adjusted time is always strictly greater than the current biological time. At t=0 the behaviour is identical to before.