Conversation
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 10515fc016
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| trace!( | ||
| "dropping tun UDP packet: {} -> {} (dns_hijack={})", | ||
| local_addr, remote_addr, dns_hijack | ||
| ); |
There was a problem hiding this comment.
This loop only processes DNS datagrams when dns_hijack is enabled and destination port is 53; every other UDP packet falls through to the dropping tun UDP packet branch and is discarded. In practice, that breaks all regular UDP traffic from TUN clients (e.g., QUIC/STUN and even DNS when dns_hijack is false), so UDP support is functionally unavailable outside the hijack path.
Useful? React with 👍 / 👎.
MFSGA
force-pushed
the
master
branch
2 times, most recently
from
824da7d to
7bb2f2e
Compare
1 participant
@codex review this and only pick the latest 2 commit to the master and help me solve the error