Feature/output stream support for html to pdf batch utils#1539
Open
Julius1st wants to merge 2 commits intoLibrePDF:masterfrom
Open
Feature/output stream support for html to pdf batch utils#1539Julius1st wants to merge 2 commits intoLibrePDF:masterfrom
Julius1st wants to merge 2 commits intoLibrePDF:masterfrom
Conversation
Up to standards ✅🟢 Issues
|
| Metric | Results |
|---|---|
| Complexity | 18 |
| Duplication | 4 |
NEW Get contextual insights on your PRs based on Codacy's metrics, along with PR and Jira context, without leaving GitHub. Enable AI reviewer
TIP This summary will be updated as you push new changes.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of the new Feature/Bugfix
Added the ability to
HtmlToPdfBatchUtilsto return rendered pdf files streamed to a user suppliedOutputStreaminstead of saving it to a path.Related Issue: Closes #1537
Unit-Tests for the new Feature/Bugfix
Compatibilities Issues
The already available methods were changed to use the newly implemented methods. This is to reduce code repetition but does not change the way they behave.
Your real name
Julius Schömer