Open
Conversation
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## develop #1715 +/- ##
===========================================
- Coverage 77.77% 77.75% -0.02%
===========================================
Files 79 79
Lines 8192 8182 -10
Branches 1259 1259
===========================================
- Hits 6371 6362 -9
+ Misses 1581 1579 -2
- Partials 240 241 +1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Member
|
Is the persistent sim example still getting tested. Remove the sim and gen versions of this variable - check no persistent sim or gen is returning data that is not needed (ie. dupcliate of whatever was returned in loop). When they should return, you can see something with update H after loop. |
…story_f from persis_sim. remove message warning that fields will be appended in upcoming release
…en explicitly updating after loop
…e latest status of the last few complete sims. So it's sim_ended count may not necessarily match sim_max
… getting respected
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.