-
Notifications
You must be signed in to change notification settings - Fork 8
Add JA4/TLS fingerprint debug endpoint at /_ts/debug/ja4 #646
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
prk-Jr
wants to merge
7
commits into
main
Choose a base branch
from
feat/ja4-debug-endpoint
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+146
−1
Open
Changes from all commits
Commits
Show all changes
7 commits
Select commit
Hold shift + click to select a range
f23c4c4
temp ja4 endpoint
prk-Jr 8af61fc
Merge branch 'main' into feat/ja4-debug-endpoint
prk-Jr 0a32bb8
Add route coverage for JA4 debug endpoint
prk-Jr f0b3bd2
Added cache control no-store private
prk-Jr 5fc6a4a
Merge branch 'main' into feat/ja4-debug-endpoint
prk-Jr bf74be9
Resolve PR review findings
prk-Jr 2ebf4ef
Resolve PR review findings
prk-Jr File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🔧 wrench —
Cache-Controlis silently overridable by operator[response_headers]The handler sets
Cache-Control: no-store, private, but the response then flows throughfinalize_response, whose final loop unconditionally callsresponse.set_header(key, value)for every operator-configured[response_headers]entry (crates/trusted-server-adapter-fastly/src/main.rs:349-351). If an operator configuresCache-Control = "public, max-age=..."(a common edge default), ourno-store, privateis silently replaced and a sensitive fingerprint response can land in shared caches.The route-level test does not catch this because
create_test_settings()does not configure[response_headers]. Thefinalize_responsedoc says "operators can intentionally override any managed header" — that contract is acceptable for cosmetic headers, not for cache-control on a debug endpoint that exposes TLS metadata.Fix: Handle this route the same way
/healthis handled — beforeroute_request/finalize_response(top ofmain(), afterinit_logger):That also avoids paying the cost of building the auction orchestrator and integration registry for a simple debug probe, and pairs naturally with the staging-only gate suggested in the other 🔧.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fixed — handler moved to
main()afterget_settings()but beforebuild_orchestrator(), same pattern as/health. Callssend_to_client()directly and returns, bypassingfinalize_responseentirely. Both the enabled and disabled (404) cases are handled there.