Buffer limit for example UDR replicate#9013
Open
Ev3nt wants to merge 1 commit intoFirebirdSQL:masterfrom
Open
Conversation
Member
|
Must say that in EXAMPLE, which is targeted to show users how to work with particular firebird feature, adding so much implementation details to avoid BOF is (on my mind) not good idea. |
Member
|
Agree with Alex. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Buffer with a static size of 65536 may be overflowing.
Details
The
replicateimplementation uses unsafestrcatandsnprintfbecause there are no size checks. If the buffer overflows, a crash occurs.