Add support double quotes as a single token in SQLNormalizer#11197
Draft
Add support double quotes as a single token in SQLNormalizer#11197
Conversation
BenchmarksStartupParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 62 metrics, 9 unstable metrics. Startup time reports for insecure-bankgantt
title insecure-bank - global startup overhead: candidate=1.62.0-SNAPSHOT~b0fbac1afe, baseline=1.62.0-SNAPSHOT~0d1c44d515b
dateFormat X
axisFormat %s
section tracing
Agent [baseline] (1.055 s) : 0, 1054933
Total [baseline] (8.879 s) : 0, 8878818
Agent [candidate] (1.056 s) : 0, 1055695
Total [candidate] (8.82 s) : 0, 8819852
section iast
Agent [baseline] (1.233 s) : 0, 1233049
Total [baseline] (9.504 s) : 0, 9503580
Agent [candidate] (1.232 s) : 0, 1232003
Total [candidate] (9.455 s) : 0, 9455290
gantt
title insecure-bank - break down per module: candidate=1.62.0-SNAPSHOT~b0fbac1afe, baseline=1.62.0-SNAPSHOT~0d1c44d515b
dateFormat X
axisFormat %s
section tracing
crashtracking [baseline] (1.235 ms) : 0, 1235
crashtracking [candidate] (1.219 ms) : 0, 1219
BytebuddyAgent [baseline] (634.994 ms) : 0, 634994
BytebuddyAgent [candidate] (634.721 ms) : 0, 634721
AgentMeter [baseline] (29.323 ms) : 0, 29323
AgentMeter [candidate] (29.369 ms) : 0, 29369
GlobalTracer [baseline] (248.735 ms) : 0, 248735
GlobalTracer [candidate] (248.517 ms) : 0, 248517
AppSec [baseline] (32.272 ms) : 0, 32272
AppSec [candidate] (32.323 ms) : 0, 32323
Debugger [baseline] (59.335 ms) : 0, 59335
Debugger [candidate] (59.667 ms) : 0, 59667
Remote Config [baseline] (595.724 µs) : 0, 596
Remote Config [candidate] (612.069 µs) : 0, 612
Telemetry [baseline] (8.025 ms) : 0, 8025
Telemetry [candidate] (7.998 ms) : 0, 7998
Flare Poller [baseline] (4.35 ms) : 0, 4350
Flare Poller [candidate] (5.134 ms) : 0, 5134
section iast
crashtracking [baseline] (1.252 ms) : 0, 1252
crashtracking [candidate] (1.241 ms) : 0, 1241
BytebuddyAgent [baseline] (811.054 ms) : 0, 811054
BytebuddyAgent [candidate] (809.571 ms) : 0, 809571
AgentMeter [baseline] (11.36 ms) : 0, 11360
AgentMeter [candidate] (11.382 ms) : 0, 11382
GlobalTracer [baseline] (239.076 ms) : 0, 239076
GlobalTracer [candidate] (239.032 ms) : 0, 239032
AppSec [baseline] (27.709 ms) : 0, 27709
AppSec [candidate] (30.409 ms) : 0, 30409
Debugger [baseline] (63.714 ms) : 0, 63714
Debugger [candidate] (64.078 ms) : 0, 64078
Remote Config [baseline] (534.278 µs) : 0, 534
Remote Config [candidate] (529.15 µs) : 0, 529
Telemetry [baseline] (7.792 ms) : 0, 7792
Telemetry [candidate] (7.782 ms) : 0, 7782
Flare Poller [baseline] (3.458 ms) : 0, 3458
Flare Poller [candidate] (3.484 ms) : 0, 3484
IAST [baseline] (31.104 ms) : 0, 31104
IAST [candidate] (28.482 ms) : 0, 28482
Startup time reports for petclinicgantt
title petclinic - global startup overhead: candidate=1.62.0-SNAPSHOT~b0fbac1afe, baseline=1.62.0-SNAPSHOT~0d1c44d515b
dateFormat X
axisFormat %s
section tracing
Agent [baseline] (1.075 s) : 0, 1075291
Total [baseline] (11.173 s) : 0, 11172695
Agent [candidate] (1.056 s) : 0, 1056294
Total [candidate] (11.037 s) : 0, 11036882
section appsec
Agent [baseline] (1.266 s) : 0, 1265878
Total [baseline] (11.186 s) : 0, 11185599
Agent [candidate] (1.271 s) : 0, 1271104
Total [candidate] (11.065 s) : 0, 11065186
section iast
Agent [baseline] (1.233 s) : 0, 1233346
Total [baseline] (11.327 s) : 0, 11326629
Agent [candidate] (1.238 s) : 0, 1238400
Total [candidate] (11.275 s) : 0, 11274561
section profiling
Agent [baseline] (1.193 s) : 0, 1193250
Total [baseline] (11.009 s) : 0, 11009129
Agent [candidate] (1.183 s) : 0, 1183137
Total [candidate] (11.139 s) : 0, 11139187
gantt
title petclinic - break down per module: candidate=1.62.0-SNAPSHOT~b0fbac1afe, baseline=1.62.0-SNAPSHOT~0d1c44d515b
dateFormat X
axisFormat %s
section tracing
crashtracking [baseline] (1.27 ms) : 0, 1270
crashtracking [candidate] (1.221 ms) : 0, 1221
BytebuddyAgent [baseline] (647.496 ms) : 0, 647496
BytebuddyAgent [candidate] (634.352 ms) : 0, 634352
AgentMeter [baseline] (30.081 ms) : 0, 30081
AgentMeter [candidate] (29.344 ms) : 0, 29344
GlobalTracer [baseline] (252.026 ms) : 0, 252026
GlobalTracer [candidate] (248.667 ms) : 0, 248667
AppSec [baseline] (32.742 ms) : 0, 32742
AppSec [candidate] (32.186 ms) : 0, 32186
Debugger [baseline] (61.164 ms) : 0, 61164
Debugger [candidate] (60.057 ms) : 0, 60057
Remote Config [baseline] (607.492 µs) : 0, 607
Remote Config [candidate] (594.298 µs) : 0, 594
Telemetry [baseline] (8.966 ms) : 0, 8966
Telemetry [candidate] (8.717 ms) : 0, 8717
Flare Poller [baseline] (4.415 ms) : 0, 4415
Flare Poller [candidate] (5.045 ms) : 0, 5045
section appsec
crashtracking [baseline] (1.222 ms) : 0, 1222
crashtracking [candidate] (1.233 ms) : 0, 1233
BytebuddyAgent [baseline] (679.076 ms) : 0, 679076
BytebuddyAgent [candidate] (680.826 ms) : 0, 680826
AgentMeter [baseline] (12.345 ms) : 0, 12345
AgentMeter [candidate] (12.317 ms) : 0, 12317
GlobalTracer [baseline] (249.702 ms) : 0, 249702
GlobalTracer [candidate] (250.586 ms) : 0, 250586
AppSec [baseline] (185.489 ms) : 0, 185489
AppSec [candidate] (187.015 ms) : 0, 187015
Debugger [baseline] (65.621 ms) : 0, 65621
Debugger [candidate] (66.294 ms) : 0, 66294
Remote Config [baseline] (578.02 µs) : 0, 578
Remote Config [candidate] (582.452 µs) : 0, 582
Telemetry [baseline] (7.826 ms) : 0, 7826
Telemetry [candidate] (7.977 ms) : 0, 7977
Flare Poller [baseline] (3.458 ms) : 0, 3458
Flare Poller [candidate] (3.513 ms) : 0, 3513
IAST [baseline] (24.186 ms) : 0, 24186
IAST [candidate] (24.344 ms) : 0, 24344
section iast
crashtracking [baseline] (1.216 ms) : 0, 1216
crashtracking [candidate] (1.227 ms) : 0, 1227
BytebuddyAgent [baseline] (810.932 ms) : 0, 810932
BytebuddyAgent [candidate] (815.246 ms) : 0, 815246
AgentMeter [baseline] (11.373 ms) : 0, 11373
AgentMeter [candidate] (11.468 ms) : 0, 11468
GlobalTracer [baseline] (238.722 ms) : 0, 238722
GlobalTracer [candidate] (239.768 ms) : 0, 239768
AppSec [baseline] (29.544 ms) : 0, 29544
AppSec [candidate] (28.425 ms) : 0, 28425
Debugger [baseline] (66.132 ms) : 0, 66132
Debugger [candidate] (64.37 ms) : 0, 64370
Remote Config [baseline] (553.138 µs) : 0, 553
Remote Config [candidate] (537.892 µs) : 0, 538
Telemetry [baseline] (7.891 ms) : 0, 7891
Telemetry [candidate] (7.813 ms) : 0, 7813
Flare Poller [baseline] (3.458 ms) : 0, 3458
Flare Poller [candidate] (3.478 ms) : 0, 3478
IAST [baseline] (27.496 ms) : 0, 27496
IAST [candidate] (30.008 ms) : 0, 30008
section profiling
crashtracking [baseline] (1.204 ms) : 0, 1204
crashtracking [candidate] (1.181 ms) : 0, 1181
BytebuddyAgent [baseline] (696.99 ms) : 0, 696990
BytebuddyAgent [candidate] (690.812 ms) : 0, 690812
AgentMeter [baseline] (8.995 ms) : 0, 8995
AgentMeter [candidate] (8.932 ms) : 0, 8932
GlobalTracer [baseline] (209.077 ms) : 0, 209077
GlobalTracer [candidate] (206.949 ms) : 0, 206949
AppSec [baseline] (32.941 ms) : 0, 32941
AppSec [candidate] (32.51 ms) : 0, 32510
Debugger [baseline] (66.134 ms) : 0, 66134
Debugger [candidate] (65.362 ms) : 0, 65362
Remote Config [baseline] (576.697 µs) : 0, 577
Remote Config [candidate] (568.943 µs) : 0, 569
Telemetry [baseline] (7.84 ms) : 0, 7840
Telemetry [candidate] (7.777 ms) : 0, 7777
Flare Poller [baseline] (3.533 ms) : 0, 3533
Flare Poller [candidate] (3.508 ms) : 0, 3508
ProfilingAgent [baseline] (94.173 ms) : 0, 94173
ProfilingAgent [candidate] (93.802 ms) : 0, 93802
Profiling [baseline] (94.738 ms) : 0, 94738
Profiling [candidate] (94.369 ms) : 0, 94369
LoadParameters
See matching parameters
SummaryFound 0 performance improvements and 4 performance regressions! Performance is the same for 16 metrics, 16 unstable metrics.
Request duration reports for insecure-bankgantt
title insecure-bank - request duration [CI 0.99] : candidate=1.62.0-SNAPSHOT~b0fbac1afe, baseline=1.62.0-SNAPSHOT~0d1c44d515b
dateFormat X
axisFormat %s
section baseline
no_agent (1.222 ms) : 1212, 1233
. : milestone, 1222,
iast (3.325 ms) : 3277, 3374
. : milestone, 3325,
iast_FULL (5.922 ms) : 5863, 5981
. : milestone, 5922,
iast_GLOBAL (3.508 ms) : 3458, 3557
. : milestone, 3508,
profiling (2.296 ms) : 2275, 2318
. : milestone, 2296,
tracing (1.873 ms) : 1858, 1888
. : milestone, 1873,
section candidate
no_agent (1.289 ms) : 1277, 1302
. : milestone, 1289,
iast (3.336 ms) : 3285, 3386
. : milestone, 3336,
iast_FULL (5.872 ms) : 5814, 5930
. : milestone, 5872,
iast_GLOBAL (3.704 ms) : 3642, 3767
. : milestone, 3704,
profiling (2.25 ms) : 2229, 2270
. : milestone, 2250,
tracing (1.89 ms) : 1874, 1906
. : milestone, 1890,
Request duration reports for petclinicgantt
title petclinic - request duration [CI 0.99] : candidate=1.62.0-SNAPSHOT~b0fbac1afe, baseline=1.62.0-SNAPSHOT~0d1c44d515b
dateFormat X
axisFormat %s
section baseline
no_agent (18.243 ms) : 18058, 18429
. : milestone, 18243,
appsec (18.898 ms) : 18706, 19091
. : milestone, 18898,
code_origins (17.721 ms) : 17549, 17894
. : milestone, 17721,
iast (17.83 ms) : 17657, 18004
. : milestone, 17830,
profiling (18.378 ms) : 18192, 18564
. : milestone, 18378,
tracing (18.284 ms) : 18105, 18464
. : milestone, 18284,
section candidate
no_agent (19.686 ms) : 19480, 19891
. : milestone, 19686,
appsec (19.531 ms) : 19333, 19729
. : milestone, 19531,
code_origins (18.925 ms) : 18734, 19117
. : milestone, 18925,
iast (17.947 ms) : 17772, 18122
. : milestone, 17947,
profiling (18.409 ms) : 18225, 18593
. : milestone, 18409,
tracing (17.704 ms) : 17532, 17876
. : milestone, 17704,
DacapoParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 12 metrics, 0 unstable metrics. Execution time for biojavagantt
title biojava - execution time [CI 0.99] : candidate=1.62.0-SNAPSHOT~b0fbac1afe, baseline=1.62.0-SNAPSHOT~0d1c44d515b
dateFormat X
axisFormat %s
section baseline
no_agent (14.922 s) : 14922000, 14922000
. : milestone, 14922000,
appsec (15.262 s) : 15262000, 15262000
. : milestone, 15262000,
iast (18.716 s) : 18716000, 18716000
. : milestone, 18716000,
iast_GLOBAL (17.845 s) : 17845000, 17845000
. : milestone, 17845000,
profiling (14.974 s) : 14974000, 14974000
. : milestone, 14974000,
tracing (14.91 s) : 14910000, 14910000
. : milestone, 14910000,
section candidate
no_agent (14.961 s) : 14961000, 14961000
. : milestone, 14961000,
appsec (14.875 s) : 14875000, 14875000
. : milestone, 14875000,
iast (18.585 s) : 18585000, 18585000
. : milestone, 18585000,
iast_GLOBAL (17.964 s) : 17964000, 17964000
. : milestone, 17964000,
profiling (15.115 s) : 15115000, 15115000
. : milestone, 15115000,
tracing (14.933 s) : 14933000, 14933000
. : milestone, 14933000,
Execution time for tomcatgantt
title tomcat - execution time [CI 0.99] : candidate=1.62.0-SNAPSHOT~b0fbac1afe, baseline=1.62.0-SNAPSHOT~0d1c44d515b
dateFormat X
axisFormat %s
section baseline
no_agent (1.492 ms) : 1481, 1504
. : milestone, 1492,
appsec (2.555 ms) : 2500, 2610
. : milestone, 2555,
iast (2.278 ms) : 2208, 2347
. : milestone, 2278,
iast_GLOBAL (2.333 ms) : 2263, 2403
. : milestone, 2333,
profiling (2.115 ms) : 2060, 2170
. : milestone, 2115,
tracing (2.087 ms) : 2033, 2141
. : milestone, 2087,
section candidate
no_agent (1.492 ms) : 1481, 1504
. : milestone, 1492,
appsec (2.556 ms) : 2501, 2611
. : milestone, 2556,
iast (2.278 ms) : 2208, 2347
. : milestone, 2278,
iast_GLOBAL (2.335 ms) : 2265, 2406
. : milestone, 2335,
profiling (2.117 ms) : 2062, 2173
. : milestone, 2117,
tracing (2.081 ms) : 2028, 2135
. : milestone, 2081,
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What Does This Do
Treat
CLOSE "this is one token"as two tokens, just like for single quotes.Motivation
Additional Notes
Contributor Checklist
type:and (comp:orinst:) labels in addition to any other useful labelsclose,fix, or any linking keywords when referencing an issueUse
solvesinstead, and assign the PR milestone to the issueJira ticket: APMS-19336
Note: Once your PR is ready to merge, add it to the merge queue by commenting
/merge./merge -ccancels the queue request./merge -f --reason "reason"skips all merge queue checks; please use this judiciously, as some checks do not run at the PR-level. For more information, see this doc.