Allow cursor-based pagination to query extra page until collection is empty#3790
Merged
Allow cursor-based pagination to query extra page until collection is empty#3790
Conversation
… empty Mirrors DataDog/datadog-api-client-go#3769. Cursor paginators now keep querying until the response data is empty, instead of stopping when a page returns fewer items than the requested limit. Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
MintsInc
approved these changes
May 5, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Mirrors datadog-api-client-go#3769 for the Java client.
Cursor-based paginators now keep querying until the response collection is empty, instead of stopping early when a page returns fewer items than the requested limit. Page-offset and page-number paginations keep their existing behavior.
cursorPaginationflag plumbed throughPaginationIterable/PaginationIterator(and the matching.j2templates).Api.j2passespagination.cursorParaminto the constructor.new PaginationIterable(...)call sites).The supporting cassettes (extra trailing
{"data":[]}response) were already added in #3559 when the Go/Ruby clients shipped this change.Test plan
mvn clean compilesucceeds@with-paginationCucumber scenarios pass (37/37)🤖 Generated with Claude Code