London | 26-ITP-Jan | Zadri Abdule | Sprint 2 | Form Control#1170
Closed
Zadri415 wants to merge 12 commits intoCodeYourFuture:mainfrom
Closed
London | 26-ITP-Jan | Zadri Abdule | Sprint 2 | Form Control#1170Zadri415 wants to merge 12 commits intoCodeYourFuture:mainfrom
Zadri415 wants to merge 12 commits intoCodeYourFuture:mainfrom
Conversation
✅ Deploy Preview for cyf-onboarding-module ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
Zadri415
added
Needs Review
Zadri415
changed the title
Zadri415
changed the title
cjyuan
reviewed
Feb 11, 2026
Contributor
cjyuan
left a comment
cjyuan
left a comment
There was a problem hiding this comment.
Code is free of syntax error and well formatted. Well done!
- Currently, a user can still submit the form without filling in all input. Can you address this issue?
cjyuan
added
Reviewed
Updated the name input field to enforce a pattern that disallows only spaces.
Contributor
Note: I just noticed this PR does not yet have a "Needs Review" label. Appologise if I reviewed your change prematurely. |
Updated input field for full name to require a minimum length of 2 characters.
Zadri415
added
the
Needs Review
Contributor
|
The spec mentions, "All fields are required", but the current implementation does not yet fulfill this requirement. |
cjyuan
removed
the
Needs Review
Updated radio button inputs to be required for color selection.
Zadri415
added
the
Needs Review
cjyuan
reviewed
Feb 12, 2026
Contributor
cjyuan
left a comment
cjyuan
left a comment
There was a problem hiding this comment.
Changes look good. Well done!
Comment on lines
+40
to
+46
| <input type="radio" name="color" value="blue" required> | ||
| Blue | ||
| </label> | ||
|
|
||
|
|
||
| <label> | ||
| <input type="radio" name="color" value="green"> | ||
| <input type="radio" name="color" value="green" required> |
Contributor
There was a problem hiding this comment.
Note: Since these radio buttons belong to the same button group, multiple required is not necessary.
cjyuan
added
Complete
Member
|
Closing PR because the January ITP run has finished. Feel free to re-open if you're still working on it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Learners, PR Template
Self checklist
Changelist
Added required input fields for name and email with validation
Added T-shirt colour radio buttons
Added size dropdown menu
Fixed HTML validator