FEATURE: Cache AIS responses to avoid redundant calls#65
Open
akupecz wants to merge 1 commit intoCityOfPhiladelphia:mainfrom
Open
FEATURE: Cache AIS responses to avoid redundant calls#65akupecz wants to merge 1 commit intoCityOfPhiladelphia:mainfrom
akupecz wants to merge 1 commit intoCityOfPhiladelphia:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Change:
Sets a global dictionary in
ais_lookup.pythat will persist for the duration of the program.This dictionary's key is the passyunk standardized address and it's value is the associated out_data variable that is created when processing the address with AIS.
The
ais_lookupfunction will now first check to see if address has already been processed. If so, it will pull the previously created ais information from the dictionary associated with address. Otherwise it will create the ais information dictionary and add it as a value for the key address.Speed Improvement
In a file with 6.3k addressess, most of which are intersections, geocoding took approximately 1 hour before the change. After the change, the same file had been geocoded within 20 minutes.